[all-commits] [llvm/llvm-project] 5ba906: [lld-macho] Fixed crashes when linking with incomp...

[Vy Nguyen via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5ba906327b0178b7635baa89710eb2967db1aa18
      https://github.com/llvm/llvm-project/commit/5ba906327b0178b7635baa89710eb2967db1aa18
  Author: Vy Nguyen <vyng at google.com>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    M lld/MachO/InputFiles.cpp
    M lld/MachO/InputFiles.h
    M lld/MachO/Symbols.h
    A lld/test/MachO/ignore-incompat-arch.s
    M lld/test/MachO/objc.s

  Log Message:
  -----------
  [lld-macho] Fixed crashes when linking with incompatible-arch archives/

Two changes:
 - Avoid crashing in predicate functions.
   Querying the property of the Symbols via these is*() functions shouldn't crash the program - the answer should just be "false".
   Currently, having them throw UNREACHABLE already (incorrectly) crash certain code paths involving macho::validateSymbolRelocation() .

 - Simply ignore input archives with incompatible arch (changes from PRESIDENT810@)

Differential Revision: https://reviews.llvm.org/D156468