[all-commits] [llvm/llvm-project] 9853e9: [libcxx] [test] Deduplicate setting parameters for...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Fri Aug 4 05:55:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9853e9b85971335ad605b86be45aafee4f7a3573
      https://github.com/llvm/llvm-project/commit/9853e9b85971335ad605b86be45aafee4f7a3573
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    M libcxx/test/CMakeLists.txt
    M libcxx/test/configs/llvm-libc++-shared-clangcl.cfg.in
    M libcxx/test/configs/llvm-libc++-shared-no-vcruntime-clangcl.cfg.in
    M libcxx/test/configs/llvm-libc++-static-clangcl.cfg.in

  Log Message:
  -----------
  [libcxx] [test] Deduplicate setting parameters for clangcl test configs. NFC.

Differential Revision: https://reviews.llvm.org/D156573


  Commit: 9b02e8d4a0abd60ae1a825e4192fc4ea67ba9049
      https://github.com/llvm/llvm-project/commit/9b02e8d4a0abd60ae1a825e4192fc4ea67ba9049
  Author: Martin Storsjö <martin at martin.st>
  Date:   2023-08-04 (Fri, 04 Aug 2023)

  Changed paths:
    M libcxx/CMakeLists.txt
    M libcxx/test/CMakeLists.txt

  Log Message:
  -----------
  [libcxx] Respect CMAKE_MSVC_RUNTIME_LIBRARY wrt whether to use the debug CRT

If CMAKE_MSVC_RUNTIME_LIBRARY isn't set, then CMake defaults to
the debug CRT, if CMAKE_BUILD_TYPE is set to Debug. If
CMAKE_MSVC_RUNTIME_LIBRARY is set though, that overrides any
implicit defaults.

Match this in libcxx's own manual linking logic. This allows
decoupling the debug CRT from the CMAKE_BUILD_TYPE and allows users
to configure their builds exactly how they want.

Differential Revision: https://reviews.llvm.org/D155561


Compare: https://github.com/llvm/llvm-project/compare/2f6ca38d51cf...9b02e8d4a0ab


More information about the All-commits mailing list