[all-commits] [llvm/llvm-project] e73ae7: [analyzer] Fix incorrect link to "note" diagnostic...

[Guruprasad Hegde via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e73ae745b0d660d3974c04b2281575f325971338
      https://github.com/llvm/llvm-project/commit/e73ae745b0d660d3974c04b2281575f325971338
  Author: Guruprasad Hegde <gruuprasada at gmail.com>
  Date:   2023-08-03 (Thu, 03 Aug 2023)

  Changed paths:
    M clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp
    A clang/test/Analysis/html_diagnostics/notes-links.cpp

  Log Message:
  -----------
  [analyzer] Fix incorrect link to "note" diagnostics in HTML output

IDs of the note list start from 1. Link generated for each note started
with index 0 i.e #Note0, #Note1 and so on.
As a result, first link ("#Note0") was invalid, subsequent links pointed
at wrong note.
Now, generated links to the notes start with index 1 i.e (#Note1, #Note2
and so on.

Patch by Guruprasad Hegde (gruuprasad)!

Fixes https://github.com/llvm/llvm-project/issues/64054

Differential Revision: https://reviews.llvm.org/D156724