[all-commits] [llvm/llvm-project] 7ef171: [Driver] Don't try to spell check unsupported options

Justin Bogner via All-commits all-commits at lists.llvm.org
Wed Aug 2 14:36:19 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7ef1718c4d4ecd99f3ba48236f7fd4fd9ffb540c
      https://github.com/llvm/llvm-project/commit/7ef1718c4d4ecd99f3ba48236f7fd4fd9ffb540c
  Author: Justin Bogner <mail at justinbogner.com>
  Date:   2023-08-02 (Wed, 02 Aug 2023)

  Changed paths:
    M clang/include/clang/Driver/Options.td
    M clang/lib/Driver/Driver.cpp
    M clang/test/Driver/unsupported-option.c
    M flang/test/Driver/driver-version.f90

  Log Message:
  -----------
  [Driver] Don't try to spell check unsupported options

We currently spell check options that are listed as unsupported, but
this doesn't make much sense. If an option is explicitly unsupported
why would one that's spelled similarly be useful?

It looks like the reason this was added was that we explicitly mark
all `--something` flags as Unsupported rather than just leaving them
undefined and treating them as unknown. Drop that handling so that we
don't regress on things like misspelling `--help`.

Differential Revision: https://reviews.llvm.org/D156925




More information about the All-commits mailing list