[all-commits] [llvm/llvm-project] 6c2e32: [lldb] Re-add compile-time checks for SPI in HosIn...

Alex via All-commits all-commits at lists.llvm.org
Wed Aug 2 10:22:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6c2e3249160f5b68f6e09fed0435ee043659f2d9
      https://github.com/llvm/llvm-project/commit/6c2e3249160f5b68f6e09fed0435ee043659f2d9
  Author: Alex Langford <alangford at apple.com>
  Date:   2023-08-02 (Wed, 02 Aug 2023)

  Changed paths:
    M lldb/source/Host/macosx/objcxx/HostInfoMacOSX.mm

  Log Message:
  -----------
  [lldb] Re-add compile-time checks for SPI in HosInfoMacOSX

There were some checks removed previously in
bc196970b549782bffde5fdbfa450c565af11fc1.

However, all these SPIs are actually defined in macOS 12 and onward, not
macOSX 10.12 as the previous commit would suggest. As a result, if you
have access to these SPIs lldb will fail to compile correctly.

Instead of adding back the __builtin_availability checks, it seems
easier just to check the minimum deployment target with Availability
macros.

Differential Revision: https://reviews.llvm.org/D156838




More information about the All-commits mailing list