[all-commits] [llvm/llvm-project] 620e2b: [mlir][LLVM] NFC - Remove createIndexConstant method

[Nicolas Vasilache via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 620e2bb20cb7f9e59a7c30eab0737e34eb26ed2d
      https://github.com/llvm/llvm-project/commit/620e2bb20cb7f9e59a7c30eab0737e34eb26ed2d
  Author: Nicolas Vasilache <nicolasvasilache at users.noreply.github.com>
  Date:   2023-08-02 (Wed, 02 Aug 2023)

  Changed paths:
    M mlir/include/mlir/Conversion/LLVMCommon/Pattern.h
    M mlir/include/mlir/Conversion/MemRefToLLVM/AllocLikeConversion.h
    M mlir/lib/Conversion/AMDGPUToROCDL/AMDGPUToROCDL.cpp
    M mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp
    M mlir/lib/Conversion/LLVMCommon/Pattern.cpp
    M mlir/lib/Conversion/MemRefToLLVM/AllocLikeConversion.cpp
    M mlir/lib/Conversion/MemRefToLLVM/MemRefToLLVM.cpp

  Log Message:
  -----------
  [mlir][LLVM] NFC - Remove createIndexConstant method

This revision removes the createIndexConstant method, which implicitly creates constants of the
getIndexType type and updates all uses to the more explicit createIndexAttrConstant which requires
an explicit Type parameter.

This is an NFC step towards entangling index type conversion in LLVM lowering.

The selection of which index type to use requires finer granularity than the existing
implementations which all rely on pass level flags and end up in mismatches, especially on GPUs
with multiple address spaces of different capacities.

This revision also includes an NFC fix to MemRefToLLVM.cpp that prevents a crash in cases where
an integer memory space cannot be derived for a MemRef.

Differential Revision: https://reviews.llvm.org/D156854