[all-commits] [llvm/llvm-project] eb0055: AMDGPU: Add more tests for sincos recognition

Matt Arsenault via All-commits all-commits at lists.llvm.org
Tue Aug 1 15:21:04 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: eb00555c16b70d7940e99a89dce72994f5790cc9
      https://github.com/llvm/llvm-project/commit/eb00555c16b70d7940e99a89dce72994f5790cc9
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-08-01 (Tue, 01 Aug 2023)

  Changed paths:
    A llvm/test/CodeGen/AMDGPU/amdgpu-simplify-libcall-sincos.defined.ll
    A llvm/test/CodeGen/AMDGPU/amdgpu-simplify-libcall-sincos.defined.nobuiltin.ll
    A llvm/test/CodeGen/AMDGPU/amdgpu-simplify-libcall-sincos.defined.sin.cos.ll
    A llvm/test/CodeGen/AMDGPU/amdgpu-simplify-libcall-sincos.ll
    A llvm/test/CodeGen/AMDGPU/amdgpu-simplify-libcall-sincos.nobuiltins.ll
    A llvm/test/CodeGen/AMDGPU/amdgpu-simplify-libcall-sincos.weak.ll

  Log Message:
  -----------
  AMDGPU: Add more tests for sincos recognition

These show both broken cases and cases which are handled too
conservatively.


  Commit: 5dfdd3494bf25b30c0161861fc080a17444e6f27
      https://github.com/llvm/llvm-project/commit/5dfdd3494bf25b30c0161861fc080a17444e6f27
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-08-01 (Tue, 01 Aug 2023)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPU.h
    M llvm/lib/Target/AMDGPU/AMDGPULibCalls.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
    M llvm/test/CodeGen/AMDGPU/llvm.amdgcn.wavefrontsize.ll

  Log Message:
  -----------
  AMDGPU: Don't try to fold wavefrontsize intrinsic in libcall simplify

It's not a libcall so doesn't really belong here to begin
with. Relying on checking the target name and explicit features isn't
particularly sound either. The library doesn't use the intrinsic
anymore, so it doesn't matter anyway.


Compare: https://github.com/llvm/llvm-project/compare/b9062179813f...5dfdd3494bf2


More information about the All-commits mailing list