[all-commits] [llvm/llvm-project] 7f12dc: [HIP] Fix regression about `__fp16` args and retur...

Yaxun (Sam) Liu via All-commits all-commits at lists.llvm.org
Tue Aug 1 08:29:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7f12dcac79f3d2653ae77cd1be0768e64ff7a518
      https://github.com/llvm/llvm-project/commit/7f12dcac79f3d2653ae77cd1be0768e64ff7a518
  Author: Yaxun (Sam) Liu <yaxun.liu at amd.com>
  Date:   2023-08-01 (Tue, 01 Aug 2023)

  Changed paths:
    M clang/lib/Basic/Targets/AMDGPU.cpp
    A clang/test/SemaCUDA/fp16-arg-return.cu

  Log Message:
  -----------
  [HIP] Fix regression about `__fp16` args and return value

HIP allows __fp16 as function arguments and return value by passing
-fallow-half-arguments-and-returns to clang through hipcc.

https://reviews.llvm.org/D133885 removed -fallow-half-arguments-and-returns
and add a TargetInfo member to control it.

This caused regressions in some HIP apps
(https://github.com/ROCm-Developer-Tools/HIP/issues/3178).

Reviewed by: Artem Belevich

Differential Revision: https://reviews.llvm.org/D145345

Fixes: https://github.com/ROCm-Developer-Tools/HIP/issues/3178




More information about the All-commits mailing list