[all-commits] [llvm/llvm-project] d542a5: [BPF] Clean up SelLowering

[Tamir Duberstein via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d542a56c1c2cc5d14a15aa6326e5a39414cd22e2
      https://github.com/llvm/llvm-project/commit/d542a56c1c2cc5d14a15aa6326e5a39414cd22e2
  Author: Tamir Duberstein <tamird at gmail.com>
  Date:   2023-08-01 (Tue, 01 Aug 2023)

  Changed paths:
    M llvm/lib/Target/BPF/BPFISelLowering.cpp
    M llvm/lib/Target/BPF/BPFISelLowering.h
    M llvm/test/CodeGen/BPF/many_args1.ll
    M llvm/test/CodeGen/BPF/many_args2.ll
    M llvm/test/CodeGen/BPF/struct_ret1.ll
    M llvm/test/CodeGen/BPF/vararg1.ll

  Log Message:
  -----------
  [BPF] Clean up SelLowering

This patch contains a number of uncontroversial changes:
- Replace all uses of
  `errs`, `assert`, `llvm_unreachable` with `report_fatal_error` with
  informative error strings.
- Replace calls to `fail` in loops with at most one call per error
  instance. Previously a function with 19 arguments would log "too many
  args" 14 times. This was not helpful.
- Change one `if (..) switch ...` to `if (..) { switch ...`. The added
  brace is consistent with a near-identical switch immediately above.
- Elide one `SDValue` copy by using a reference rather than value. This
  is consistent with a variable declared immediately before it.

Reviewed By: yonghong-song

Differential Revision: https://reviews.llvm.org/D156136