[all-commits] [llvm/llvm-project] fcb6a9: [Flang][OpenMP][Lower] Refactor implementation of ...

Sergio Afonso via All-commits all-commits at lists.llvm.org
Mon Jul 31 02:53:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fcb6a9c07cf7a2bc63d364e3b7f60aaadadd57cc
      https://github.com/llvm/llvm-project/commit/fcb6a9c07cf7a2bc63d364e3b7f60aaadadd57cc
  Author: Sergio Afonso <safonsof at amd.com>
  Date:   2023-07-31 (Mon, 31 Jul 2023)

  Changed paths:
    M flang/lib/Lower/OpenMP.cpp

  Log Message:
  -----------
  [Flang][OpenMP][Lower] Refactor implementation of PFT to MLIR lowering

This patch makes the following non-functional changes:
  - Extract OpenMP clause processing into a new internal `ClauseProcessor`
    class. Atomic and reduction-related clauses processing is kept unchanged,
    since atomic clauses are stored in `OmpAtomicClauseList` rather than
    `OmpClauseList` and there are many TODO comments related to the current
    implementation of reduction lowering. This has been left unchanged to avoid
    merge conflicts and work duplication.
  - Reorganize functions into sections in the file to improve readability.
  - Explicitly use mlir:: namespace everywhere, rather than just most places.
  - Spell out uses of `auto` in which the type wasn't explicitly stated as part
    of the initialization expression.
  - Normalize a few function names to match the rest and renamed variables in
    'snake_case' to 'camelCase'.

The main purpose is to reduce code duplication and simplify the implementation
of upcoming work to support loop-attached target constructs and teams/
distribute lowering to MLIR.

Differential Revision: https://reviews.llvm.org/D155981




More information about the All-commits mailing list