[all-commits] [llvm/llvm-project] 26a730: [X86] Split SDISel call lowering out to its own file

Reid Kleckner via All-commits all-commits at lists.llvm.org
Fri Jul 28 09:24:37 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 26a730821d48b86fe78fb854ee7ce3f64d696119
      https://github.com/llvm/llvm-project/commit/26a730821d48b86fe78fb854ee7ce3f64d696119
  Author: Reid Kleckner <rnk at google.com>
  Date:   2023-07-28 (Fri, 28 Jul 2023)

  Changed paths:
    M llvm/lib/Target/X86/CMakeLists.txt
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/lib/Target/X86/X86ISelLowering.h
    A llvm/lib/Target/X86/X86ISelLoweringCall.cpp
    M llvm/utils/gn/secondary/llvm/lib/Target/X86/BUILD.gn

  Log Message:
  -----------
  [X86] Split SDISel call lowering out to its own file

X86ISelLowering takes too long to compile. Split call lowering out into
its own file so that developers working on call lowering can be more
productive.

Now one can test calling convention changes with <5s rebuilds. The rest
of X86ISelLowering still takes a long time to compile. Previous
investigations shows that lots of static functions are aggressively
inlined into the two major large switch functions, LowerOperation and
PerformDAGCombine. It may be possible to make further compile time
improvements by blocking inlining into those large dispatch functions.

clang-format complains, but I didn't want to reformat because it will
make it harder for git rename detection and blame tools.

Reviewed By: RKSimon, pengfei

Differential Revision: https://reviews.llvm.org/D154168




More information about the All-commits mailing list