[all-commits] [llvm/llvm-project] 9ea44c: [llvm-objdump] -d: don't display mapping symbols a...

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9ea44c6894270546d6d88ef0d3abcf1e1876acae
      https://github.com/llvm/llvm-project/commit/9ea44c6894270546d6d88ef0d3abcf1e1876acae
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-07-27 (Thu, 27 Jul 2023)

  Changed paths:
    M lld/test/ELF/aarch64-call26-thunk.s
    M lld/test/ELF/aarch64-cortex-a53-843419-large.s
    M lld/test/ELF/aarch64-jump26-thunk.s
    M lld/test/ELF/aarch64-range-thunk-extension-plt32.s
    M lld/test/ELF/aarch64-relocs.s
    M lld/test/ELF/aarch64-thunk-reuse2.s
    M lld/test/ELF/arm-bl-v4.s
    M lld/test/ELF/arm-bl-v4t.s
    M lld/test/ELF/arm-bl-v6.s
    M lld/test/ELF/arm-bx-v4t.s
    M lld/test/ELF/arm-fpic-got.s
    M lld/test/ELF/arm-gnu-ifunc-plt.s
    M lld/test/ELF/arm-gnu-ifunc.s
    M lld/test/ELF/arm-got-relative.s
    M lld/test/ELF/arm-plt-reloc.s
    M lld/test/ELF/arm-target1.s
    M lld/test/ELF/arm-thumb-interwork-ifunc.s
    M lld/test/ELF/arm-thumb-interwork-shared.s
    M lld/test/ELF/arm-thumb-interwork-thunk-v5.s
    M lld/test/ELF/arm-thumb-interwork-thunk.s
    M lld/test/ELF/arm-thumb-plt-range-thunk-os.s
    M lld/test/ELF/arm-thumb-plt-reloc.s
    M lld/test/ELF/arm-thumb-range-thunk-os-no-ext.s
    M lld/test/ELF/arm-thunk-arm-thumb-reuse.s
    M lld/test/ELF/arm-thunk-largesection.s
    M lld/test/ELF/arm-thunk-multipass-plt.s
    M lld/test/ELF/arm-thunk-re-add.s
    M lld/test/ELF/pr34660.s
    M llvm/include/llvm/MC/MCDisassembler/MCDisassembler.h
    M llvm/test/tools/llvm-objdump/ELF/AArch64/disassemble-align.s
    M llvm/test/tools/llvm-objdump/ELF/AArch64/elf-aarch64-mapping-symbols.test
    M llvm/test/tools/llvm-objdump/ELF/ARM/disassemble-all-mapping-symbols.s
    M llvm/tools/llvm-objdump/llvm-objdump.cpp
    M llvm/tools/llvm-objdump/llvm-objdump.h

  Log Message:
  -----------
  [llvm-objdump] -d: don't display mapping symbols as labels

Similar to D96617 for llvm-symbolizer.

This patch matches the GNU objdump -d behavior to suppress printing
labels for mapping symbols. Mapping symbol names don't convey much
information.

When --show-all-symbols (not in GNU) is specified, we still print
mapping symbols.

Note: the `for (size_t SI = 0, SE = Symbols.size(); SI != SE;)` loops
needs to iterate all mapping symbols, even if they are not displayed.
We use the new field `IsMappingSymbol` to recognize mapping symbols.
This field also enables simplification after D139131.

ELF/ARM/disassemble-all-mapping-symbols.s is enhanced to add `.space 2`.
If `End = std::min(End, Symbols[SI].Addr);` is not correctly set, we
would print a `.word`.

Reviewed By: jhenderson, jobnoorman, peter.smith

Differential Revision: https://reviews.llvm.org/D156190