[all-commits] [llvm/llvm-project] f1c21f: [AArch64] Switch magic numbers to library function...

Daniel Hoekwater via All-commits all-commits at lists.llvm.org
Thu Jul 27 14:30:11 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f1c21faeb2f66822895271c37de6d4b0ed6a5dce
      https://github.com/llvm/llvm-project/commit/f1c21faeb2f66822895271c37de6d4b0ed6a5dce
  Author: Daniel Hoekwater <hoekwater at google.com>
  Date:   2023-07-27 (Thu, 27 Jul 2023)

  Changed paths:
    M llvm/lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp

  Log Message:
  -----------
  [AArch64] Switch magic numbers to library functions in fixup

Using masks and bounds that are magic numbers means that defects
in bounds checking and offset masking are subtle and hard to
detect. https://reviews.llvm.org/D152841 is an example of this
type of defect. Switching to clearly readable library functions
makes defects less obfuscated.

Differential Revision: https://reviews.llvm.org/D152843




More information about the All-commits mailing list