[all-commits] [llvm/llvm-project] 52647a: HIP: Fix broken version check for deprecated macro

Thu Jul 27 06:38:23 PDT 2023

  Branch: refs/heads/release/17.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 52647ad0275c9bf76a78b6cb2575fd0be697819f
      https://github.com/llvm/llvm-project/commit/52647ad0275c9bf76a78b6cb2575fd0be697819f
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-07-27 (Thu, 27 Jul 2023)

  Changed paths:
    M clang/lib/Headers/__clang_hip_libdevice_declares.h

  Log Message:
  -----------
  HIP: Fix broken version check for deprecated macro

Remove test hack that was accidentally pushed.

(cherry picked from commit 73105a54725ec11165dd8c90ca3b7a0b1b9cd6e3)

  Commit: cd2570ae9cdd399e54af029cf1dc51350462d2fd
      https://github.com/llvm/llvm-project/commit/cd2570ae9cdd399e54af029cf1dc51350462d2fd
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-07-27 (Thu, 27 Jul 2023)

  Changed paths:
    M llvm/include/llvm/ADT/FunctionExtras.h
    M llvm/include/llvm/ADT/SmallVector.h
    M llvm/include/llvm/Support/type_traits.h
    M llvm/unittests/Support/TypeTraitsTest.cpp
    M mlir/lib/Dialect/SparseTensor/IR/Detail/TemplateExtras.h

  Log Message:
  -----------
  [Support] Remove llvm::is_trivially_{copy/move}_constructible

This restores D132311, which was reverted in
29c841ce93e087fa4e0c5f3abae94edd460bc24a (Sep 2022) due to certain files
not buildable with GCC 7.3.0. The previous attempt was reverted by
6cd9608fb37ca2418fb44b57ec955bb5efe10689 (Dec 2020).

This time, GCC 7.3.0 has existing build errors for a long time due to
structured bindings for many files, e.g.

```
llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:9098:13: error: cannot decompose class type ‘std::pair<llvm::Value*, const llvm::SCEV*>’: both it and it
s base class ‘std::pair<llvm::Value*, const llvm::SCEV*>’ have non-static data members
   for (auto [_, Stride] : Legal->getLAI()->getSymbolicStrides()) {
             ^~~~~~~~~~~
```

... and also some `error: duplicate initialization of` instances due to llvm/Transforms/IPO/Attributor.h.

---

GCC 7.5.0 has a bug that, without this change, certain `SmallVector` with a `std::pair` element type like `SmallVector<std::pair<Instruction * const, Info>, 0> X;` lead to spurious

```
/tmp/opt/gcc-7.5.0/include/c++/7.5.0/type_traits:878:48: error: constructor required before non-static data member for ‘...’ has been parsed
```

Switching to std::is_trivially_{copy/move}_constructible fixes the error.

(cherry picked from commit 6a684dbc4433a33e5f94fb15c9e378a2408021e0)

  Commit: 1993d2f322b81912a0e84ab015d3cefa1aecbc4d
      https://github.com/llvm/llvm-project/commit/1993d2f322b81912a0e84ab015d3cefa1aecbc4d
  Author: David Green <david.green at arm.com>
  Date:   2023-07-27 (Thu, 27 Jul 2023)

  Changed paths:
    A llvm/test/CodeGen/AArch64/fmlal-loreg.ll

  Log Message:
  -----------
  [AArch64] Add test showing incorrect register usage of FMLAL. NFC

See D156296

(cherry picked from commit e012c5cfac8542eb8164bab9891ea9b355e73517)

  Commit: 1de314f828fd502440eb0466503a8397005f5e36
      https://github.com/llvm/llvm-project/commit/1de314f828fd502440eb0466503a8397005f5e36
  Author: David Green <david.green at arm.com>
  Date:   2023-07-27 (Thu, 27 Jul 2023)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrFormats.td
    M llvm/test/CodeGen/AArch64/fmlal-loreg.ll

  Log Message:
  -----------
  [AArch64] Correct the regtype of indexed fmlal

The indexed fmlal should use a low numbered register for the index operand,
which this fixes by making it V128_lo.

Fixes 64104

Differential Revision: https://reviews.llvm.org/D156296

(cherry picked from commit 509cb334699a2360f2d87f184bc0f56f742c6fc3)

  Commit: d4a6c50f7a25a0fe5336c2d8cb6509f852852ddd
      https://github.com/llvm/llvm-project/commit/d4a6c50f7a25a0fe5336c2d8cb6509f852852ddd
  Author: Viktoriia Bakalova <bakalova at google.com>
  Date:   2023-07-27 (Thu, 27 Jul 2023)

  Changed paths:
    M clang-tools-extra/clangd/index/SymbolCollector.cpp
    M clang-tools-extra/clangd/index/SymbolCollector.h
    M clang-tools-extra/clangd/unittests/FileIndexTests.cpp
    M clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp

  Log Message:
  -----------
  [clangd] Revert the symbol collector behavior to old pre-include-cleaner-library behavior due to a regression.

Differential Revision: https://reviews.llvm.org/D156403

(cherry picked from commit 3c6a7b0045afe9a230346e476bf07f88c145fdb5)

  Commit: 02ccc2a8fff1f63afbdfa81274549122d5e7d574
      https://github.com/llvm/llvm-project/commit/02ccc2a8fff1f63afbdfa81274549122d5e7d574
  Author: WANG Xuerui <git at xen0n.name>
  Date:   2023-07-27 (Thu, 27 Jul 2023)

  Changed paths:
    M lld/test/ELF/loongarch-add-sub.s

  Log Message:
  -----------
  [lld][ELF][test] Fix excessive output file size in loongarch-add-sub.s

Initially the .rodata section came before .text, hence sharing its
segment with the program header sitting at a small offset, pushing the
output file size to ~72GiB (the file was sparse though, so not much is
really written). This breaks on 32-bit platforms and is irrelevant to
the feature being tested, so re-order the two sections so .text gets
processed first, and both sections get their own segment.

This addresses the issue found by the clang-armv8-lld-2stage builder:
    https://lab.llvm.org/buildbot/#/builders/178/builds/5340

Reviewed By: SixWeining, xry111

Differential Revision: https://reviews.llvm.org/D156293

(cherry picked from commit ffe2b6f75de55b665520669059c3d95240482d54)

Compare: https://github.com/llvm/llvm-project/compare/bc849e525f80...02ccc2a8fff1