[all-commits] [llvm/llvm-project] 867f2d: [scudo] Make Options a reference for functions.

Christopher Ferris via All-commits all-commits at lists.llvm.org
Wed Jul 26 18:22:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 867f2d9e5c9a736eb97fe5a51aa2850abfd02a96
      https://github.com/llvm/llvm-project/commit/867f2d9e5c9a736eb97fe5a51aa2850abfd02a96
  Author: Christopher Ferris <cferris at google.com>
  Date:   2023-07-26 (Wed, 26 Jul 2023)

  Changed paths:
    M compiler-rt/lib/scudo/standalone/combined.h
    M compiler-rt/lib/scudo/standalone/options.h
    M compiler-rt/lib/scudo/standalone/secondary.h

  Log Message:
  -----------
  [scudo] Make Options a reference for functions.

Modify all places that use the Options structure to be a const
reference. The underlying structure is a u32 so making it a
reference doesn't really do anything. However, if the structure
changes in the future it already works and avoids future coders
wondering why a structure is being passed by value. This also
makes it clear that the Options should not be modified in those functions.

Reviewed By: Chia-hungDuan

Differential Revision: https://reviews.llvm.org/D156372




More information about the All-commits mailing list