[all-commits] [llvm/llvm-project] f6307b: [include-cleaner] Switch Include from FileEntry* -...

Sam McCall via All-commits all-commits at lists.llvm.org
Wed Jul 26 04:42:15 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f6307b260b0c0d93d25d13bab7ec02d762f4a2a6
      https://github.com/llvm/llvm-project/commit/f6307b260b0c0d93d25d13bab7ec02d762f4a2a6
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2023-07-26 (Wed, 26 Jul 2023)

  Changed paths:
    M clang-tools-extra/clang-tidy/misc/IncludeCleanerCheck.cpp
    M clang-tools-extra/clangd/IncludeCleaner.cpp
    M clang-tools-extra/include-cleaner/include/clang-include-cleaner/Types.h
    M clang-tools-extra/include-cleaner/lib/Analysis.cpp
    M clang-tools-extra/include-cleaner/lib/Record.cpp
    M clang-tools-extra/include-cleaner/lib/Types.cpp
    M clang-tools-extra/include-cleaner/unittests/RecordTest.cpp
    M clang-tools-extra/include-cleaner/unittests/TypesTest.cpp

  Log Message:
  -----------
  [include-cleaner] Switch Include from FileEntry* -> FileEntryRef

Unlike Header, we really do have a preferred spelling for an include: the one
that we used to open the file.

The fact that Header is still FileEntry* makes it difficult to accidentally
use path equality when we want inode equality.

Differential Revision: https://reviews.llvm.org/D155885




More information about the All-commits mailing list