[all-commits] [llvm/llvm-project] 2ee4d0: [Verifier] definition subprograms cannot be nested...

[DianQK via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2ee4d0386c783f58abe708298228de648239b435
      https://github.com/llvm/llvm-project/commit/2ee4d0386c783f58abe708298228de648239b435
  Author: DianQK <dianqk at dianqk.net>
  Date:   2023-07-26 (Wed, 26 Jul 2023)

  Changed paths:
    M llvm/lib/IR/Verifier.cpp
    A llvm/test/Verifier/disubprogram-declaration-within-struct-2.ll
    A llvm/test/Verifier/disubprogram-declaration-within-struct.ll

  Log Message:
  -----------
  [Verifier] definition subprograms cannot be nested within DICompositeType when enabling ODR.

Resolve https://github.com/llvm/llvm-project/issues/61932. We should add the validation.

LLVM can't handle IR where subprogram definitions are nested within DICompositeType when doing LTO builds, because there's no good way to cross the CU boundary to insert a nested DISubprogram definition in one CU into a type defined in another CU.

The test cases `cross-cu-inlining-2.ll` and `cross-cu-inlining-ranges.ll` can be deleted. In the `cross-cu-inlining-2.ll`, the low pc and high pc of the CU are also incorrect.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D152095