[all-commits] [llvm/llvm-project] 488c3d: [libc++][mdspan] Fix uglification, categorize asse...

Christian Trott via All-commits all-commits at lists.llvm.org
Tue Jul 25 11:40:24 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 488c3db245ce0fe3b70357d6798ee91c5baa82a2
      https://github.com/llvm/llvm-project/commit/488c3db245ce0fe3b70357d6798ee91c5baa82a2
  Author: Christian Trott <crtrott at sandia.gov>
  Date:   2023-07-25 (Tue, 25 Jul 2023)

  Changed paths:
    M libcxx/include/__mdspan/extents.h
    M libcxx/include/__mdspan/layout_left.h
    M libcxx/include/__mdspan/layout_right.h
    M libcxx/include/__mdspan/mdspan.h
    A libcxx/test/libcxx/containers/views/mdspan/extents/assert.conversion.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/extents/assert.ctor_from_array.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/extents/assert.ctor_from_integral.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/extents/assert.ctor_from_span.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/extents/assert.obs.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/layout_left/assert.conversion.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/layout_left/assert.ctor.extents.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/layout_left/assert.ctor.layout_right.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/layout_left/assert.index_operator.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/layout_left/assert.stride.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/layout_right/assert.conversion.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/layout_right/assert.ctor.extents.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/layout_right/assert.ctor.layout_left.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/layout_right/assert.index_operator.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/layout_right/assert.stride.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/mdspan/assert.conversion.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/mdspan/assert.index_operator.pass.cpp
    A libcxx/test/libcxx/containers/views/mdspan/mdspan/assert.size.pass.cpp
    R libcxx/test/std/containers/views/mdspan/extents/assert.conversion.pass.cpp
    R libcxx/test/std/containers/views/mdspan/extents/assert.ctor_from_array.pass.cpp
    R libcxx/test/std/containers/views/mdspan/extents/assert.ctor_from_integral.pass.cpp
    R libcxx/test/std/containers/views/mdspan/extents/assert.ctor_from_span.pass.cpp
    R libcxx/test/std/containers/views/mdspan/extents/assert.obs.pass.cpp
    R libcxx/test/std/containers/views/mdspan/layout_left/assert.conversion.pass.cpp
    R libcxx/test/std/containers/views/mdspan/layout_left/assert.ctor.extents.pass.cpp
    R libcxx/test/std/containers/views/mdspan/layout_left/assert.ctor.layout_right.pass.cpp
    R libcxx/test/std/containers/views/mdspan/layout_left/assert.index_operator.pass.cpp
    R libcxx/test/std/containers/views/mdspan/layout_left/assert.stride.pass.cpp
    R libcxx/test/std/containers/views/mdspan/layout_right/assert.conversion.pass.cpp
    R libcxx/test/std/containers/views/mdspan/layout_right/assert.ctor.extents.pass.cpp
    R libcxx/test/std/containers/views/mdspan/layout_right/assert.ctor.layout_left.pass.cpp
    R libcxx/test/std/containers/views/mdspan/layout_right/assert.index_operator.pass.cpp
    R libcxx/test/std/containers/views/mdspan/layout_right/assert.stride.pass.cpp
    R libcxx/test/std/containers/views/mdspan/mdspan/assert.conversion.pass.cpp
    R libcxx/test/std/containers/views/mdspan/mdspan/assert.index_operator.pass.cpp
    R libcxx/test/std/containers/views/mdspan/mdspan/assert.size.pass.cpp

  Log Message:
  -----------
  [libc++][mdspan] Fix uglification, categorize asserts and move tests

Fixes uglification in mdspan deduction guides, which CI
did not test for until recently. The CI modification
and mdspan testing overlapped, so mdspan landed with green
CI, and the CI modification landed too.

Make most assertions in mdspan and its helper classes
trigger during a hardened build in order to catch
out of bounds access errors.

Also moves all mdspan assertions tests from libcxx/test/std
to libcxx/test/libcxx.

Differential Revision: https://reviews.llvm.org/156181




More information about the All-commits mailing list