[all-commits] [llvm/llvm-project] 0478ef: [clangd] Exclude builtin headers from system inclu...

Sam McCall via All-commits all-commits at lists.llvm.org
Tue Jul 25 09:19:53 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0478ef2d366c6f88678e37d54190dcdaa0ec69da
      https://github.com/llvm/llvm-project/commit/0478ef2d366c6f88678e37d54190dcdaa0ec69da
  Author: Sam McCall <sam.mccall at gmail.com>
  Date:   2023-07-25 (Tue, 25 Jul 2023)

  Changed paths:
    M clang-tools-extra/clangd/SystemIncludeExtractor.cpp
    M clang-tools-extra/clangd/test/system-include-extractor.test

  Log Message:
  -----------
  [clangd] Exclude builtin headers from system include extraction

Most headers that we discover are likely to be fairly portable across at least
clang/gcc, which is why we get away with adding them to clangd's search path.

This is not the case for the compiler builtin headers, which are shipped with
the parser and rely on parser builtins/features. We're better off *not* using
the the scanned builtin headers, and hoping our own intrinsics provide the
interface the code is relying on.

Fixes https://github.com/clangd/clangd/issues/1695

Differential Revision: https://reviews.llvm.org/D156044




More information about the All-commits mailing list