[all-commits] [llvm/llvm-project] cdc6f4: [builtins] Fix building trunc*fhf2_test with GCC

Alexander Richardson via All-commits all-commits at lists.llvm.org
Mon Jul 24 17:20:27 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cdc6f4cdcdb5a30840dfbc34a981c9e19adc7996
      https://github.com/llvm/llvm-project/commit/cdc6f4cdcdb5a30840dfbc34a981c9e19adc7996
  Author: Alex Richardson <alexrichardson at google.com>
  Date:   2023-07-24 (Mon, 24 Jul 2023)

  Changed paths:
    M compiler-rt/test/builtins/Unit/truncdfhf2_test.c
    M compiler-rt/test/builtins/Unit/truncsfhf2_test.c

  Log Message:
  -----------
  [builtins] Fix building trunc*fhf2_test with GCC

GCC does not support __fp16, use the TYPE_FP16 macro instead.

Differential Revision: https://reviews.llvm.org/D153813


  Commit: b1149400122be1a9c713f3c31674a4f9b765c2d4
      https://github.com/llvm/llvm-project/commit/b1149400122be1a9c713f3c31674a4f9b765c2d4
  Author: Alex Richardson <alexrichardson at google.com>
  Date:   2023-07-24 (Mon, 24 Jul 2023)

  Changed paths:
    M compiler-rt/test/builtins/Unit/test
    M compiler-rt/test/builtins/Unit/trampoline_setup_test.c

  Log Message:
  -----------
  [builtins] Drop -fnested-functions flag from tests

This flag does nothing for clang and is apparently not supported by GCC:
aarch64-linux-gnu-gcc: error: unrecognized command-line option '-fnested-functions'; did you mean '-Wunused-function'?
It looks like it was maybe supported by Apple GCC, but that is no longer
a supported compiler.

Differential Revision: https://reviews.llvm.org/D153819


  Commit: e3374c8c31fb54a2c8df6c906884e14f1c8a2209
      https://github.com/llvm/llvm-project/commit/e3374c8c31fb54a2c8df6c906884e14f1c8a2209
  Author: Alex Richardson <alexrichardson at google.com>
  Date:   2023-07-24 (Mon, 24 Jul 2023)

  Changed paths:
    M compiler-rt/lib/builtins/addtf3.c
    M compiler-rt/lib/builtins/comparetf2.c
    M compiler-rt/lib/builtins/divtf3.c
    M compiler-rt/lib/builtins/extenddftf2.c
    M compiler-rt/lib/builtins/extendhftf2.c
    M compiler-rt/lib/builtins/extendsftf2.c
    M compiler-rt/lib/builtins/fixtfdi.c
    M compiler-rt/lib/builtins/fixtfsi.c
    M compiler-rt/lib/builtins/fixtfti.c
    M compiler-rt/lib/builtins/fixunstfdi.c
    M compiler-rt/lib/builtins/fixunstfsi.c
    M compiler-rt/lib/builtins/fixunstfti.c
    M compiler-rt/lib/builtins/floatditf.c
    M compiler-rt/lib/builtins/floatsitf.c
    M compiler-rt/lib/builtins/floattitf.c
    M compiler-rt/lib/builtins/floatunditf.c
    M compiler-rt/lib/builtins/floatunsitf.c
    M compiler-rt/lib/builtins/floatuntitf.c
    M compiler-rt/lib/builtins/fp_lib.h
    M compiler-rt/lib/builtins/multf3.c
    M compiler-rt/lib/builtins/powitf2.c
    M compiler-rt/lib/builtins/subtf3.c
    M compiler-rt/lib/builtins/trunctfdf2.c
    M compiler-rt/lib/builtins/trunctfhf2.c
    M compiler-rt/lib/builtins/trunctfsf2.c

  Log Message:
  -----------
  [builtins] Avoid using CRT_LDBL_128BIT in implementation. NFC

Currently the *tf builtin functions can only be built if long double is an
IEEE float, which prevents them from being available e.g. for x86 targets
(unlike libgcc which has them). This non-functional change prepares the
builtins library *tf functions for being able to target x86 by decoupling
their presence from CRT_LDBL_128BIT and instead checking for a
CRT_HAS_TF_MODE macro. This change is NFC since the CRT_HAS_TF_MODE is
currently only set if long double is an IEEE 128-bit float.

Reviewed By: compnerd

Differential Revision: https://reviews.llvm.org/D153812


Compare: https://github.com/llvm/llvm-project/compare/a09d9b42f162...e3374c8c31fb


More information about the All-commits mailing list