[all-commits] [llvm/llvm-project] c381a9: [libc] Remove test RPC opcodes from the exported h...

Joseph Huber via All-commits all-commits at lists.llvm.org
Fri Jul 21 13:36:55 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c381a947531ff31f510a7719fade9da73ec45078
      https://github.com/llvm/llvm-project/commit/c381a947531ff31f510a7719fade9da73ec45078
  Author: Joseph Huber <jhuber6 at vols.utk.edu>
  Date:   2023-07-21 (Fri, 21 Jul 2023)

  Changed paths:
    M libc/docs/gpu/rpc.rst
    M libc/include/llvm-libc-types/rpc_opcodes_t.h
    A libc/include/llvm-libc-types/test_rpc_opcodes_t.h
    M libc/test/integration/startup/gpu/rpc_interface_test.cpp
    M libc/test/integration/startup/gpu/rpc_stream_test.cpp
    M libc/test/integration/startup/gpu/rpc_test.cpp
    M libc/utils/gpu/loader/Loader.h
    M libc/utils/gpu/loader/amdgpu/Loader.cpp
    M libc/utils/gpu/loader/nvptx/Loader.cpp
    M libc/utils/gpu/server/rpc_server.cpp
    M libc/utils/gpu/server/rpc_server.h

  Log Message:
  -----------
  [libc] Remove test RPC opcodes from the exported header

This patch does the noisy work of removing the test opcodes from the
exported interface to an interface that is only visible in `libc`. The
benefit of this is that we both test the exported RPC registration more
directly, and we do not need to give this interface to users.

I have decided to export any opcode that is not a "core" libc feature as
having its MSB set in the opcode. We can think of these as non-libc
"extensions".

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D154848




More information about the All-commits mailing list