[all-commits] [llvm/llvm-project] 7baf5d: [modularize] Stabilize iteration order when proces...

Fangrui Song via All-commits all-commits at lists.llvm.org
Thu Jul 20 22:44:36 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7baf5d3841ee16df66e218b1b892d3d2a3f0680b
      https://github.com/llvm/llvm-project/commit/7baf5d3841ee16df66e218b1b892d3d2a3f0680b
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-07-20 (Thu, 20 Jul 2023)

  Changed paths:
    M clang-tools-extra/modularize/ModularizeUtilities.cpp
    M clang-tools-extra/test/modularize/ProblemsDisplayLists.modularize

  Log Message:
  -----------
  [modularize] Stabilize iteration order when processing module maps

Many diagnostics (e.g., ProblemsDuplicate.modularize,
ProblemsDisplayLists.modularize) are dependent on the iteration order of
StringMap, which is not guaranteed to be deterministic
(https://llvm.org/docs/ProgrammersManual.html#llvm-adt-stringmap-h).
clang::ModuleMap::Modules is a StringMap. For now, sort by name in
modularize.




More information about the All-commits mailing list