[all-commits] [llvm/llvm-project] 881e9f: AMDGPU: Regenerate test checks

Matt Arsenault via All-commits all-commits at lists.llvm.org
Thu Jul 20 16:30:10 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 881e9f29342af0e59cdc173e428abe609fb599c8
      https://github.com/llvm/llvm-project/commit/881e9f29342af0e59cdc173e428abe609fb599c8
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-07-20 (Thu, 20 Jul 2023)

  Changed paths:
    M llvm/test/CodeGen/AMDGPU/amdgpu-codegenprepare-fdiv.ll
    M llvm/test/CodeGen/AMDGPU/fdiv32-to-rcp-folding.ll

  Log Message:
  -----------
  AMDGPU: Regenerate test checks

Mostly a workaround for recent reverts in update_test_checks


  Commit: fb54afd1b7a5287f521759badf0a72c5ab544ca8
      https://github.com/llvm/llvm-project/commit/fb54afd1b7a5287f521759badf0a72c5ab544ca8
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-07-20 (Thu, 20 Jul 2023)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUGISel.td
    M llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUISelDAGToDAG.h
    M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
    M llvm/lib/Target/AMDGPU/AMDGPUInstructionSelector.h
    M llvm/lib/Target/AMDGPU/SIInstrInfo.td
    M llvm/lib/Target/AMDGPU/SIInstructions.td
    M llvm/lib/Target/AMDGPU/VOPCInstructions.td
    M llvm/lib/Target/AMDGPU/VOPInstructions.td
    M llvm/test/CodeGen/AMDGPU/fdiv32-to-rcp-folding.ll
    M llvm/test/CodeGen/AMDGPU/fneg-combines.ll
    M llvm/test/CodeGen/AMDGPU/fneg-combines.new.ll
    M llvm/test/CodeGen/AMDGPU/fsub-as-fneg-src-modifier.ll
    M llvm/test/CodeGen/AMDGPU/llvm.exp.ll

  Log Message:
  -----------
  AMDGPU: Fold fsub [+-0] into fneg when folding source modifiers

This isn't always folded to fneg for a freestanding fsub depending on
the denormal mode. When matching source modifiers, we're implicitly
canonicalizing the input so we can fold it here.

Doesn't bother handling the VOP3P case since it's only relevant with
DAZ, which nobody really uses with f16.

For f64, tests show an existing bug where DAGCombiner tries to respect
the denormal mode for fsub -0, x, but not after it's lowered to fadd
-0, (fneg x). Either the fold is wrong or we shouldn't restrict the
fsub case based on the denormal mode.

https://reviews.llvm.org/D155652


Compare: https://github.com/llvm/llvm-project/compare/889f4bf26406...fb54afd1b7a5


More information about the All-commits mailing list