[all-commits] [llvm/llvm-project] 5fdf86: [DX] Fix PSV resource serialization

Chris B via All-commits all-commits at lists.llvm.org
Wed Jul 19 16:02:52 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5fdf8605102014825dc79e1859f218228dbcd15f
      https://github.com/llvm/llvm-project/commit/5fdf8605102014825dc79e1859f218228dbcd15f
  Author: Chris Bieneman <chris.bieneman at me.com>
  Date:   2023-07-19 (Wed, 19 Jul 2023)

  Changed paths:
    M llvm/include/llvm/Object/DXContainer.h
    M llvm/include/llvm/ObjectYAML/DXContainerYAML.h
    M llvm/lib/MC/DXContainerPSVInfo.cpp
    M llvm/lib/Object/DXContainer.cpp
    M llvm/lib/ObjectYAML/DXContainerYAML.cpp
    M llvm/test/ObjectYAML/DXContainer/PSVv0-amplification.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv0-compute.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv0-domain.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv0-geometry.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv0-hull.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv0-mesh.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv0-pixel.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv0-vertex.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv1-amplification.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv1-compute.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv1-domain.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv1-geometry.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv1-hull.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv1-mesh.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv1-pixel.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv1-vertex.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv2-amplification.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv2-compute.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv2-domain.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv2-geometry.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv2-hull.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv2-mesh.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv2-pixel.yaml
    M llvm/test/ObjectYAML/DXContainer/PSVv2-vertex.yaml
    M llvm/tools/obj2yaml/dxcontainer2yaml.cpp
    M llvm/unittests/Object/DXContainerTest.cpp

  Log Message:
  -----------
  [DX] Fix PSV resource serialization

When writing this initially I missed including the resource stride.
This change adds the resources stride to the serialized value.

I've also extended the testing and error reporting around parsing PSV
information. This adds tests to verify that the reader produces
meaningful error messages for malformed DXContainer files, and a test
that verifies the resource stride is respected in the reader even if
the stride isn't an expected or known value (as would happen if the
format changes in the future).

This is part of #59479.

Reviewed By: bogner, bob80905

Differential Revision: https://reviews.llvm.org/D155143




More information about the All-commits mailing list