[all-commits] [llvm/llvm-project] 3d1f89: [lldb-vscode] Creating a new flag for adjusting th...

John Harrison via All-commits all-commits at lists.llvm.org
Wed Jul 19 14:05:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3d1f89c2e37c4cf9017842a7d04ae07a5e096d08
      https://github.com/llvm/llvm-project/commit/3d1f89c2e37c4cf9017842a7d04ae07a5e096d08
  Author: John Harrison <harjohn at google.com>
  Date:   2023-07-19 (Wed, 19 Jul 2023)

  Changed paths:
    M lldb/packages/Python/lldbsuite/test/tools/lldb-vscode/vscode.py
    M lldb/test/API/tools/lldb-vscode/completions/TestVSCode_completions.py
    M lldb/test/API/tools/lldb-vscode/console/TestVSCode_console.py
    M lldb/test/API/tools/lldb-vscode/module/TestVSCode_module.py
    M lldb/test/API/tools/lldb-vscode/startDebugging/TestVSCode_startDebugging.py
    M lldb/tools/lldb-vscode/Options.td
    M lldb/tools/lldb-vscode/README.md
    M lldb/tools/lldb-vscode/VSCode.cpp
    M lldb/tools/lldb-vscode/VSCode.h
    M lldb/tools/lldb-vscode/lldb-vscode.cpp

  Log Message:
  -----------
  [lldb-vscode] Creating a new flag for adjusting the behavior of evaluation repl expressions to allow users to more easily invoke lldb commands.

This adds a new flag and lldb runtime command to allow users to manage the behavior of the lldb-vscode evaluate repl request.

When evaluating a repl context this now has runtime managed flag for control how the repl behaviors with the follow values:

* `variable` - the existing behavior, with this mode requests are evaluted in the current frame context as variable expressions. To trigger a lldb command prefix an expression with ` and it will be evaluted as an lldb command.
* `command` - all expressions are evaluated as lldb commands.
* `auto` - An alternative mode that will attempt to determine if the expression is an lldb command or a variable expression. Based off the intepreted results the expression will be evaluted either as a command or an expression.

Additionally, I enabled completions and ensured they work with the new repl expression behavior to provide auto-completes.

This commit includes updates to the tests to verify the new behavior after the previous failures from submitting https://reviews.llvm.org/D154030.

Differential Revision: https://reviews.llvm.org/D155248




More information about the All-commits mailing list