[all-commits] [llvm/llvm-project] 941524: [mlir][spirv] Split op implementation file into su...

Jakub Kuderski via All-commits all-commits at lists.llvm.org
Wed Jul 19 13:51:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9415241c5ba700379d67006391e50204df4f32f4
      https://github.com/llvm/llvm-project/commit/9415241c5ba700379d67006391e50204df4f32f4
  Author: Jakub Kuderski <kubak at google.com>
  Date:   2023-07-19 (Wed, 19 Jul 2023)

  Changed paths:
    R mlir/include/mlir/Dialect/SPIRV/IR/ParserUtils.h
    M mlir/lib/Dialect/SPIRV/IR/CMakeLists.txt
    A mlir/lib/Dialect/SPIRV/IR/CooperativeMatrixOps.cpp
    A mlir/lib/Dialect/SPIRV/IR/IntegerDotProductOps.cpp
    A mlir/lib/Dialect/SPIRV/IR/JointMatrixOps.cpp
    M mlir/lib/Dialect/SPIRV/IR/SPIRVDialect.cpp
    A mlir/lib/Dialect/SPIRV/IR/SPIRVOpUtils.h
    M mlir/lib/Dialect/SPIRV/IR/SPIRVOps.cpp
    A mlir/lib/Dialect/SPIRV/IR/SPIRVParsingUtils.cpp
    A mlir/lib/Dialect/SPIRV/IR/SPIRVParsingUtils.h

  Log Message:
  -----------
  [mlir][spirv] Split op implementation file into subfiles. NFC.

The main op implementation file for SPIR-V grew past 5k LOC. This makes it
take a long time to compile and index with LSPs like clangd.

Pull out the first few SPIR-V extension ops into their own `.cpp` files,
just like we do with `.td` op definitions. This includes the
KHR/NV/Intel coop matrix and the integer dot prod extensions.

I plan to further split this in future revisions.

Reviewed By: antiagainst

Differential Revision: https://reviews.llvm.org/D155747




More information about the All-commits mailing list