[all-commits] [llvm/llvm-project] 9d072b: [mlir][NFC] Avoid `OpBuilder::setListener` when po...

Matthias Springer via All-commits all-commits at lists.llvm.org
Wed Jul 19 00:13:56 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9d072bbe0f0725eb22d2f2d175c64f3a9cbfb788
      https://github.com/llvm/llvm-project/commit/9d072bbe0f0725eb22d2f2d175c64f3a9cbfb788
  Author: Matthias Springer <me at m-sp.org>
  Date:   2023-07-19 (Wed, 19 Jul 2023)

  Changed paths:
    M mlir/include/mlir/Transforms/OneToNTypeConversion.h
    M mlir/lib/Conversion/OpenACCToSCF/OpenACCToSCF.cpp
    M mlir/lib/Dialect/Affine/IR/AffineOps.cpp
    M mlir/lib/Transforms/Utils/OneToNTypeConversion.cpp

  Log Message:
  -----------
  [mlir][NFC] Avoid `OpBuilder::setListener` when possible

`setListener` is dangerous because an already registered listener may accidentally be overwritten/replaced. (A `ForwardingListener` must be used in such cases.) This change updates a few trivial call sites of `setListener`, where no forwarding listener is needed.

Differential Revision: https://reviews.llvm.org/D155599




More information about the All-commits mailing list