[all-commits] [llvm/llvm-project] 88a68d: [OpenMP][NFCI] Split assertion message from assert...

Johannes Doerfert via All-commits all-commits at lists.llvm.org
Tue Jul 18 16:57:31 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 88a68de14cf66d067be54b8127c17b51192f2aa8
      https://github.com/llvm/llvm-project/commit/88a68de14cf66d067be54b8127c17b51192f2aa8
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2023-07-18 (Tue, 18 Jul 2023)

  Changed paths:
    M openmp/libomptarget/DeviceRTL/include/Debug.h
    M openmp/libomptarget/DeviceRTL/include/State.h
    M openmp/libomptarget/DeviceRTL/src/Debug.cpp
    M openmp/libomptarget/DeviceRTL/src/Kernel.cpp
    M openmp/libomptarget/DeviceRTL/src/Mapping.cpp
    M openmp/libomptarget/DeviceRTL/src/Parallelism.cpp
    M openmp/libomptarget/DeviceRTL/src/State.cpp
    M openmp/libomptarget/DeviceRTL/src/Synchronization.cpp

  Log Message:
  -----------
  [OpenMP][NFCI] Split assertion message from assertion expression

We ended up with `llvm.assume(icmp ne ptr as(4) null, as(4) @str)`
because the string in address space 4 was not known to be non-null.
There is no need to create these assumes.


  Commit: f914208c4388780e24ed3a1ab2e170c53129b2a1
      https://github.com/llvm/llvm-project/commit/f914208c4388780e24ed3a1ab2e170c53129b2a1
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2023-07-18 (Tue, 18 Jul 2023)

  Changed paths:
    M openmp/libomptarget/DeviceRTL/include/State.h
    M openmp/libomptarget/DeviceRTL/src/Mapping.cpp
    M openmp/libomptarget/DeviceRTL/src/Parallelism.cpp
    M openmp/libomptarget/DeviceRTL/src/State.cpp

  Log Message:
  -----------
  [OpenMP][NFCI] Avoid storing non-constant values in ICV

If we store a constant in an ICV it is easier for the optimizer to
propagate it. Since we often use the full block for the thread limit and
the parallel team size, we can instead replace that dynamic value with a
constant that otherwise cannot occur, here 0.


Compare: https://github.com/llvm/llvm-project/compare/621d1d07d9c4...f914208c4388


More information about the All-commits mailing list