[all-commits] [llvm/llvm-project] 39670a: [clang][analyzer] Add and change NoteTags in StdLi...

[Balázs Kéri via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 39670ae3b93470b2d29fe78e6d40c5d82a05e4a1
      https://github.com/llvm/llvm-project/commit/39670ae3b93470b2d29fe78e6d40c5d82a05e4a1
  Author: Balázs Kéri <balazs.keri at ericsson.com>
  Date:   2023-07-18 (Tue, 18 Jul 2023)

  Changed paths:
    M clang/lib/StaticAnalyzer/Checkers/ErrnoModeling.cpp
    M clang/lib/StaticAnalyzer/Checkers/ErrnoModeling.h
    M clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
    M clang/test/Analysis/errno-stdlibraryfunctions-notes.c
    M clang/test/Analysis/std-c-library-functions-arg-constraints-note-tags.cpp
    M clang/test/Analysis/std-c-library-functions-arg-constraints.c
    M clang/test/Analysis/std-c-library-functions-path-notes.c
    M clang/test/Analysis/stream-errno-note.c
    M clang/test/Analysis/stream-note.c

  Log Message:
  -----------
  [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

Change 1: ErrnoChecker notes show only messages related to errno,
not to assumption of success or failure of functions.
Change 2: StdLibraryFunctionsChecker adds its own note about success
or failure of functions, and the errno related note, independently.
Change 3: Every modeled function in StdLibraryFunctionsChecker
should have a note tag message in all "cases". This is not implemented yet,
only for file (stream) related functions.

Reviewed By: donat.nagy

Differential Revision: https://reviews.llvm.org/D153612


  Commit: f12808ab20369c85ddb602e5a78bab40d16bb83f
      https://github.com/llvm/llvm-project/commit/f12808ab20369c85ddb602e5a78bab40d16bb83f
  Author: Balázs Kéri <balazs.keri at ericsson.com>
  Date:   2023-07-18 (Tue, 18 Jul 2023)

  Changed paths:
    M clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
    M clang/test/Analysis/errno-stdlibraryfunctions-notes.c
    M clang/test/Analysis/std-c-library-functions-arg-constraints-note-tags.cpp
    M clang/test/Analysis/std-c-library-functions-arg-constraints.c
    M clang/test/Analysis/std-c-library-functions-path-notes.c
    M clang/test/Analysis/stream-errno-note.c
    M clang/test/Analysis/stream-note.c

  Log Message:
  -----------
  [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

The note tag that was previously added in all cases when a standard function call
is found is displayed now only if the function call (return value) is "interesting".
This results in less unneeded notes but some of the previously good notes disappear
too. This is because interestingness is not always set as it should be.

Reviewed By: donat.nagy

Differential Revision: https://reviews.llvm.org/D153776


  Commit: 6dccf5b8d550911f06e492a3a75c640c05efdab3
      https://github.com/llvm/llvm-project/commit/6dccf5b8d550911f06e492a3a75c640c05efdab3
  Author: Balázs Kéri <balazs.keri at ericsson.com>
  Date:   2023-07-18 (Tue, 18 Jul 2023)

  Changed paths:
    M clang/lib/StaticAnalyzer/Checkers/StdLibraryFunctionsChecker.cpp
    M clang/test/Analysis/Inputs/std-c-library-functions-POSIX.h
    M clang/test/Analysis/std-c-library-functions-POSIX.c
    M clang/test/Analysis/std-c-library-functions-arg-constraints.c

  Log Message:
  -----------
  [clang][analyzer] Add all success/failure messages to StdLibraryFunctionsChecker.

Success or failure messages are now shown at all checked functions, if the call
(return value) is interesting.
Additionally new functions are added: open, openat, socket, shutdown

Reviewed By: donat.nagy

Differential Revision: https://reviews.llvm.org/D154423


Compare: https://github.com/llvm/llvm-project/compare/4214f15660a6...6dccf5b8d550