[all-commits] [llvm/llvm-project] 497953: [ADT] Remove SFINAE constraint from llvm::iterator...

Balazs Benics via All-commits all-commits at lists.llvm.org
Tue Jul 18 00:15:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 497953b498ca6bb18bd67dc6e63f6e32ce36b2e0
      https://github.com/llvm/llvm-project/commit/497953b498ca6bb18bd67dc6e63f6e32ce36b2e0
  Author: Balazs Benics <benicsbalazs at gmail.com>
  Date:   2023-07-18 (Tue, 18 Jul 2023)

  Changed paths:
    M llvm/include/llvm/ADT/iterator_range.h

  Log Message:
  -----------
  [ADT] Remove SFINAE constraint from llvm::iterator_range ctor for gcc-7

It turns out the SFINAE constraint breaks building MLIR using GCC-7,
which is an outdated, but supported compiler by llvm-project.

I tried to find a solution for fixing it, but I decided to cut branches
and just simply remove the SFINAE constraint until we drop GCC-7.
It was originally introduced by D152891.

Allegedly, GCC-8 and above builds just fine.
I tested GCC 8.4.0, and GCC 7.5.0, and now builds fine on both.

Differential Revision: https://reviews.llvm.org/D155441

Fixes https://github.com/llvm/llvm-project/issues/63843




More information about the All-commits mailing list