[all-commits] [llvm/llvm-project] fdf36c: [lldb][AArch64] Fix flakiness in TestSVEThreadedDy...
David Spickett via All-commits
all-commits at lists.llvm.org
Mon Jul 17 01:11:32 PDT 2023
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: fdf36c3d4b467a48b628c96cc7e34c2f4bf090da
https://github.com/llvm/llvm-project/commit/fdf36c3d4b467a48b628c96cc7e34c2f4bf090da
Author: David Spickett <david.spickett at linaro.org>
Date: 2023-07-17 (Mon, 17 Jul 2023)
Changed paths:
M lldb/test/API/commands/register/register/aarch64_sve_registers/rw_access_dynamic_resize/TestSVEThreadedDynamic.py
Log Message:
-----------
[lldb][AArch64] Fix flakiness in TestSVEThreadedDynamic
This test runs to a breakpoint on thread 0. Thread 0 then starts
thread 2 and 3, which both have breakpoints in them.
In https://lab.llvm.org/buildbot/#/builders/96/builds/41674
I think that we managed to do the first check on thread 2 before
thread 3 had started. Therefore "thread continue 3" failed.
So wait for all three to startup before we check their status.
I considered putting a timeout on the while like the wait_for... methods,
but the test itself already has a global timeout. Plus, I'd rather
not be tuning a timeout per piece of hardware this runs on.
99% of the time we will already have 3 threads when the check is done.
Reviewed By: omjavaid
Differential Revision: https://reviews.llvm.org/D154705
More information about the All-commits
mailing list