[all-commits] [llvm/llvm-project] 555165: [lldb] Add missing StringExtras.h includes

Elliot Goodrich via All-commits all-commits at lists.llvm.org
Sun Jul 9 06:11:06 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5551657b310b0f5f97b26288f87bc41a8050bf93
  Author: Elliot Goodrich <elliotgoodrich at gmail.com>
  Date:   2023-07-09 (Sun, 09 Jul 2023)

  Changed paths:
    M lldb/source/Core/SourceLocationSpec.cpp
    M lldb/source/Plugins/Process/Linux/Procfs.cpp
    M lldb/source/Plugins/SymbolFile/NativePDB/CompileUnitIndex.h
    M lldb/source/Utility/DataExtractor.cpp
    M lldb/source/Utility/Event.cpp
    M lldb/source/Utility/FileSpec.cpp
    M lldb/source/Utility/Scalar.cpp
    M lldb/source/Utility/StructuredData.cpp

  Log Message:
  [lldb] Add missing StringExtras.h includes

In preparation for removing the `#include "llvm/ADT/StringExtras.h"`
from the header to source file of `llvm/Support/Error.h`, first add in
all the missing includes that were previously included transitively
through this header.

This is fixing all files missed in b0abd4893fa1, 39d8e6e22cd1, and

Differential Revision: https://reviews.llvm.org/D154775

  Commit: 4c0cfd870f78c3f107b23a2bd61504c8ebc22912
  Author: Elliot Goodrich <elliotgoodrich at gmail.com>
  Date:   2023-07-09 (Sun, 09 Jul 2023)

  Changed paths:
    M llvm/include/llvm/Support/Error.h
    M llvm/lib/Support/Error.cpp

  Log Message:
  [Support] Move StringExtras.h include from Error.h to Error.cpp

Move the implementation of the `toString` function from
`llvm/Support/Error.h` to the source file, which allows us to move
`#include "llvm/ADT/StringExtras.h"` to the source file as well.

As `Error.h` is present in a large number of translation units this
means we are unnecessarily bringing in the contents of
`StringExtras.h` - itself a large file with lots of includes - and
slowing down compilation.

Also move the `#include "llvm/ADT/SmallVector.h"` directive to the
source file as it's no longer needed, but this does not give as much of
a benefit.

This reduces the total number of preprocessing tokens across the LLVM
source files in lib from (roughly) 1,920,413,050 to 1,903,629,230 - a
reduction of ~0.87%. This should result in a small improvement in
compilation time.

Differential Revision: https://reviews.llvm.org/D154775

Compare: https://github.com/llvm/llvm-project/compare/71513a71cdf3...4c0cfd870f78

More information about the All-commits mailing list