[all-commits] [llvm/llvm-project] a11efd: Add missing StringExtras.h includes

Elliot Goodrich via All-commits all-commits at lists.llvm.org
Sat Jul 8 12:16:46 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: a11efd49266f6cf2a98bdf52428b0c9423158846
  Author: Elliot Goodrich <elliotgoodrich at gmail.com>
  Date:   2023-07-08 (Sat, 08 Jul 2023)

  Changed paths:
    M lldb/source/Host/common/File.cpp
    M lldb/source/Host/common/Socket.cpp
    M lldb/source/Host/common/XML.cpp
    M llvm/lib/WindowsDriver/MSVCPaths.cpp
    M openmp/libomptarget/src/omptarget.cpp

  Log Message:
  Add missing StringExtras.h includes

In preparation for removing the `#include "llvm/ADT/StringExtras.h"`
from the header to source file of `llvm/Support/Error.h`, first add in
all the missing includes that were previously included transitively
through this header.

This is fixing all files missed in b0abd4893fa1 and

Differential Revision: https://reviews.llvm.org/D154763

  Commit: 2e2743b6479c9d90c85a0bf68d83d45c7f9f472d
  Author: Elliot Goodrich <elliotgoodrich at gmail.com>
  Date:   2023-07-08 (Sat, 08 Jul 2023)

  Changed paths:
    M llvm/include/llvm/Support/Error.h
    M llvm/lib/Support/Error.cpp

  Log Message:
  [Support] Move StringExtras.h include from Error.h to Error.cpp

Move the implementation of the `toString` function from
`llvm/Support/Error.h` to the source file, which allows us to move
`#include "llvm/ADT/StringExtras.h"` to the source file as well.

As `Error.h` is present in a large number of translation units this
means we are unnecessarily bringing in the contents of
`StringExtras.h` - itself a large file with lots of includes - and
slowing down compilation.

Also move the `#include "llvm/ADT/SmallVector.h"` directive to the
source file as it's no longer needed, but this does not give as much of
a benefit.

This reduces the total number of preprocessing tokens across the LLVM
source files in lib from (roughly) 1,920,413,050 to 1,903,629,230 - a
reduction of ~0.87%. This should result in a small improvement in
compilation time.

Differential Revision: https://reviews.llvm.org/D154763

Compare: https://github.com/llvm/llvm-project/compare/f69b9b7cce04...2e2743b6479c

More information about the All-commits mailing list