[all-commits] [llvm/llvm-project] de7781: Revert "[DWARF][BOLT] Implement new mechanism for ...

[Nico Weber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: de7781ea4285ad13057567d531272f443edbcfd4
      https://github.com/llvm/llvm-project/commit/de7781ea4285ad13057567d531272f443edbcfd4
  Author: Nico Weber <thakis at chromium.org>
  Date:   2023-07-07 (Fri, 07 Jul 2023)

  Changed paths:
    R bolt/include/bolt/Core/DIEBuilder.h
    M bolt/include/bolt/Core/DebugData.h
    M bolt/include/bolt/Rewrite/DWARFRewriter.h
    M bolt/lib/Core/CMakeLists.txt
    R bolt/lib/Core/DIEBuilder.cpp
    M bolt/lib/Core/DebugData.cpp
    M bolt/lib/Rewrite/CMakeLists.txt
    M bolt/lib/Rewrite/DWARFRewriter.cpp
    M bolt/lib/Rewrite/RewriteInstance.cpp
    R bolt/test/X86/Inputs/dwarf4-cross-reference-different-abbrev-dst.s
    R bolt/test/X86/Inputs/dwarf4-cross-reference-different-abbrev-src.s
    R bolt/test/X86/Inputs/dwarf4-duplicate-types-helper.s
    R bolt/test/X86/Inputs/dwarf4-duplicate-types-main.s
    R bolt/test/X86/Inputs/dwarf4-gdb-index-types-helper.s
    R bolt/test/X86/Inputs/dwarf4-gdb-index-types-main.s
    R bolt/test/X86/Inputs/dwarf4-gdb-index-types-v8.gdb-index
    R bolt/test/X86/Inputs/dwarf4-split-gdb-index-types-helper.s
    R bolt/test/X86/Inputs/dwarf4-split-gdb-index-types-main.s
    R bolt/test/X86/Inputs/dwarf4-split-gdb-index-types-v8.gdb-index
    R bolt/test/X86/Inputs/dwarf4-types-dwarf5-helper.s
    R bolt/test/X86/Inputs/dwarf4-types-dwarf5-main.s
    R bolt/test/X86/Inputs/dwarf4-types-dwarf5-types-helper.s
    R bolt/test/X86/Inputs/dwarf4-types-dwarf5-types-main.s
    R bolt/test/X86/Inputs/dwarf4-types-helper.s
    R bolt/test/X86/Inputs/dwarf4-types-helper2.s
    R bolt/test/X86/Inputs/dwarf4-types-main.s
    R bolt/test/X86/Inputs/dwarf5-dwarf4-gdb-index-types-v8.generted-gdb11.gdb-index
    R bolt/test/X86/Inputs/dwarf5-dwarf4-gdb-index-types-v8.generted-gdb9.gdb-index
    R bolt/test/X86/Inputs/dwarf5-dwarf4-types-backward-forward-cross-reference-helper.s
    R bolt/test/X86/Inputs/dwarf5-dwarf4-types-backward-forward-cross-reference-main.s
    R bolt/test/X86/Inputs/dwarf5-gdb-index-types-helper.s
    R bolt/test/X86/Inputs/dwarf5-gdb-index-types-main.s
    R bolt/test/X86/Inputs/dwarf5-gdb-index-types-v8.generted-gdb11.gdb-index
    R bolt/test/X86/Inputs/dwarf5-gdb-index-types-v8.generted-gdb9.gdb-index
    M bolt/test/X86/Inputs/dwarf5-helper1-addr-section-reuse.s
    M bolt/test/X86/Inputs/dwarf5-helper2-addr-section-reuse.s
    R bolt/test/X86/Inputs/dwarf5-locexpr-referrence-helper.s
    R bolt/test/X86/Inputs/dwarf5-locexpr-referrence-main.s
    R bolt/test/X86/Inputs/dwarf5-split-gdb-index-types-helper.s
    R bolt/test/X86/Inputs/dwarf5-split-gdb-index-types-main.s
    R bolt/test/X86/Inputs/dwarf5-split-gdb-index-types-v8.gdb-index
    R bolt/test/X86/Inputs/dwarf5-types-helper2.s
    M bolt/test/X86/asm-func-debug.test
    M bolt/test/X86/dwarf3-lowpc-highpc-convert.s
    R bolt/test/X86/dwarf4-cross-cu-backward-different-abbrev.test
    R bolt/test/X86/dwarf4-cross-cu-forward-different-abbrev.test
    R bolt/test/X86/dwarf4-duplicate-types.test
    R bolt/test/X86/dwarf4-ftypes-dwo-mono-input-dwp-output.test
    M bolt/test/X86/dwarf4-ftypes-dwp-input-dwo-output.test
    M bolt/test/X86/dwarf4-ftypes-dwp-input-dwp-output.test
    R bolt/test/X86/dwarf4-gdb-index-types-gdb-generated.test
    R bolt/test/X86/dwarf4-gdb-index-types-lld-generated.test
    R bolt/test/X86/dwarf4-sibling.s
    R bolt/test/X86/dwarf4-split-gdb-index-types-gdb-generated.test
    R bolt/test/X86/dwarf4-types-dwarf5-types.test
    R bolt/test/X86/dwarf4-types-dwarf5.test
    R bolt/test/X86/dwarf4-types-forward-backward-cross-reference.s
    R bolt/test/X86/dwarf4-types.test
    R bolt/test/X86/dwarf5-dwarf4-gdb-index-types-gdb-generated-gdb11.test
    R bolt/test/X86/dwarf5-dwarf4-gdb-index-types-gdb-generated-gdb9.test
    R bolt/test/X86/dwarf5-dwarf4-gdb-index-types-lld-generated.test
    M bolt/test/X86/dwarf5-dwarf4-monolithic.test
    R bolt/test/X86/dwarf5-dwarf4-types-backward-forward-cross-reference.test
    R bolt/test/X86/dwarf5-ftypes-dwo-mono-input-dwp-output.test
    R bolt/test/X86/dwarf5-gdb-index-types-gdb-generated-gdb11.test
    R bolt/test/X86/dwarf5-gdb-index-types-gdb-generated-gdb9.test
    R bolt/test/X86/dwarf5-gdb-index-types-lld-generated.test
    R bolt/test/X86/dwarf5-locexpr-referrence.test
    M bolt/test/X86/dwarf5-loclist-offset-form.test
    M bolt/test/X86/dwarf5-split-dwarf4-monolithic.test
    R bolt/test/X86/dwarf5-split-gdb-index-types-gdb-generated.test
    R bolt/test/X86/dwarf5-types-backward-cross-reference.s
    R bolt/test/X86/dwarf5-types-forward-cross-reference.s
    M bolt/test/X86/shared-abbrev.s
    M llvm/include/llvm/CodeGen/DIE.h
    M llvm/include/llvm/DebugInfo/DWARF/DWARFFormValue.h
    M llvm/lib/DebugInfo/DWARF/DWARFFormValue.cpp

  Log Message:
  -----------
  Revert "[DWARF][BOLT] Implement new mechanism for DWARFRewriter"

This reverts commit 460a2244430fae192298a5fd9fa2a269e540e8c1.
It breaks building on macOS, and it was landed with a review URL
pointing to some Facebook-internal service.

Also reverts a bunch of follow-ups:

Revert "[BOLT][DWARF] Don't check string offsets"
This reverts commit f9d6f48c8bf5acaac07502403c41cf0b0d89c8d2.

Revert "[BOLT][DWARF] Change to process and write out TUs first then CUs in batches"
This reverts commit 88e95c1e4bb6e2ad3bfd185b96341ad5c09eff6b.

Revert "[BOLT][DWARF] Output DWO files as they are being processed"
This reverts commit 46ca2e3fcd419b1246357ed3b9cd36630f16e64d.

Revert "[BOLT][DWARF] Don't check string offsets"
This reverts commit cfe4a4b04f219a9dbb4e3fc01883437b6ff0e702.

Revert "[BOLT][DWARF] Numerous fixes for a new DWARFRewriter"
This reverts commit 2701a661daa393ad5901ac88d420d7aa931eda0d.