[all-commits] [llvm/llvm-project] fd8929: [lldb] Fix crash when completing register names af...

David Spickett via All-commits all-commits at lists.llvm.org
Thu Jul 6 01:35:24 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fd8929904d8820629bae940bce5141ef65bcaa11
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2023-07-06 (Thu, 06 Jul 2023)

  Changed paths:
    M lldb/source/Commands/CommandCompletions.cpp
    M lldb/test/API/functionalities/completion/TestCompletion.py

  Log Message:
  [lldb] Fix crash when completing register names after program exit

Previously the following would crash:
(lldb) run
Process 2594053 launched: '/tmp/test.o' (aarch64)
Process 2594053 exited with status = 0 (0x00000000)
(lldb) register read <tab>

As the completer assumed that the execution context would always
have a register context. After a program has finished, it does not.

Split out the generic parts of the test from the x86 specific tests,
and added "register info" to both.

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D154413

More information about the All-commits mailing list