[all-commits] [llvm/llvm-project] e0e36e: [lldb] Fix incorrect uses of LLDB_LOG_ERROR

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e0e36e3725b50ac690d1839f0e9476e93ff7988d
      https://github.com/llvm/llvm-project/commit/e0e36e3725b50ac690d1839f0e9476e93ff7988d
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2023-07-05 (Wed, 05 Jul 2023)

  Changed paths:
    M lldb/source/Breakpoint/Watchpoint.cpp
    M lldb/source/Core/ValueObjectRegister.cpp
    M lldb/source/Plugins/Language/CPlusPlus/BlockPointer.cpp
    M lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp
    M lldb/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp
    M lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugAranges.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
    M lldb/source/Plugins/SymbolFile/NativePDB/SymbolFileNativePDB.cpp
    M lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp
    M lldb/source/Plugins/SystemRuntime/MacOSX/AppleGetItemInfoHandler.cpp
    M lldb/source/Symbol/Type.cpp
    M lldb/source/Target/StackFrame.cpp
    M lldb/source/Target/Target.cpp
    M lldb/source/Target/ThreadPlanTracer.cpp

  Log Message:
  -----------
  [lldb] Fix incorrect uses of LLDB_LOG_ERROR

Fix incorrect uses of LLDB_LOG_ERROR. The macro doesn't automatically
inject the error in the log message: it merely passes the error as the
first argument to formatv and therefore must be referenced with {0}.

Thanks to Nicholas Allegra for collecting a list of places where the
macro was misused.

rdar://111581655

Differential revision: https://reviews.llvm.org/D154530


  Commit: 520681e56d3ab9a9f187a1f9c805ff281b815d55
      https://github.com/llvm/llvm-project/commit/520681e56d3ab9a9f187a1f9c805ff281b815d55
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2023-07-05 (Wed, 05 Jul 2023)

  Changed paths:
    M lldb/source/API/SBTarget.cpp
    M lldb/source/Core/Debugger.cpp
    M lldb/source/Core/ThreadedCommunication.cpp
    M lldb/source/Host/common/ProcessLaunchInfo.cpp
    M lldb/source/Target/Process.cpp

  Log Message:
  -----------
  [lldb] Fix incorrect uses of formatv specifiers in LLDB_LOG

Fix incorrect uses of formatv specifiers in LLDB_LOG. Unlike Python,
arguments must be numbered. All the affected log statements take
llvm:Errors so use the LLDB_LOG_ERROR macro instead.

Differential revision: https://reviews.llvm.org/D154532


Compare: https://github.com/llvm/llvm-project/compare/1ac3e13c3e4a...520681e56d3a