[all-commits] [llvm/llvm-project] 8a3fdf: [UTC] Add fallback support for specific metadata, ...

[Henrik G. Olsson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8a3fdf7b908978625e9a7e57fbb443e4e6f98976
      https://github.com/llvm/llvm-project/commit/8a3fdf7b908978625e9a7e57fbb443e4e6f98976
  Author: Henrik G. Olsson <hnrklssn at gmail.com>
  Date:   2023-07-05 (Wed, 05 Jul 2023)

  Changed paths:
    A clang/test/utils/update_cc_test_checks/Inputs/annotations.c
    A clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected
    A clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.all.expected
    M clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.generated.expected
    A clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.no-generated.all.expected
    M clang/test/utils/update_cc_test_checks/Inputs/generated-funcs.c.no-generated.expected
    A clang/test/utils/update_cc_test_checks/annotations.test
    M clang/test/utils/update_cc_test_checks/check-globals.test
    M clang/test/utils/update_cc_test_checks/generated-funcs.test
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs.ll.generated.globals.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs.ll.nogenerated.globals.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs_prefix_reuse.ll.generated.globals.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/generated_funcs_prefix_reuse.ll.nogenerated.globals.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/various_ir_values.ll.funcsig.globals.expected
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/various_ir_values.ll.funcsig.noglobals.expected
    A llvm/test/tools/UpdateTestChecks/update_test_checks/Inputs/various_ir_values.ll.funcsig.transitiveglobals.expected
    M llvm/test/tools/UpdateTestChecks/update_test_checks/various_ir_values.test
    M llvm/utils/UpdateTestChecks/common.py
    M llvm/utils/update_cc_test_checks.py
    M llvm/utils/update_test_checks.py

  Log Message:
  -----------
  [UTC] Add fallback support for specific metadata, and check their defs

This prevents update_cc_tests.py from emitting hard-coded identifiers
for metadata (global variable checkers still check hard-coded
identifiers). Instead it emits regex checkers that match even if the
identifiers change. Also adds a new mode for --check-globals: instead of
simply being on or off, it now has the options 'none', 'smart' and
'all', with 'none' and 'all' corresponding to the previous modes.

The 'smart' mode only emits checks for global definitions referenced
in the IR or other metadata that itself has a definition checker
emitted, making the rule transitive. It does not emit checks for
attribute sets, since that is better checked by --check-attributes. This
mode is made the new default. To make the change in default mode
backwards compatible a version bump is introduced (to v3), and the
default remains 'none' in v1 & v2.

This will result in metadata checks being emitted more often, so filters
are added to not check absolute file paths and compiler version git
hashes.

rdar://105239218