[all-commits] [llvm/llvm-project] 535693: [llvm][TableGen][Jupyter] Record current python wh...

David Spickett via All-commits all-commits at lists.llvm.org
Wed Jul 5 00:59:04 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 535693f8f74d539a4b34f2d226cdef8d71405d47
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2023-07-05 (Wed, 05 Jul 2023)

  Changed paths:
    M llvm/utils/TableGen/jupyter/README.md
    R llvm/utils/TableGen/jupyter/tablegen_kernel/assets/kernel.json
    M llvm/utils/TableGen/jupyter/tablegen_kernel/install.py

  Log Message:
  [llvm][TableGen][Jupyter] Record current python when kernel is installed

Previously the kernel.json would always point to `python3` even if you
installed using a python from a virtualenv. This meant that tools like VSCode
would try to run the kernel against the system python and fail.

Added a note to the readme about it. I've removed the need to
add to PYTHONPTHON as well, turns out it wasn't needed.

This fixes an issue reported in https://discourse.llvm.org/t/tablegen-the-playground-ipynb-file-is-not-working-as-expected/71745.

Reviewed By: awarzynski

Differential Revision: https://reviews.llvm.org/D154351

More information about the All-commits mailing list