[all-commits] [llvm/llvm-project] 8e7609: [lldb][AArch64] Fix tagged watch test on Graviton 3

David Spickett via All-commits all-commits at lists.llvm.org
Tue Jul 4 03:16:22 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8e76093ae8fe1184006ca14d7ffb01df982f0f43
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2023-07-04 (Tue, 04 Jul 2023)

  Changed paths:
    M lldb/test/API/commands/watchpoints/watch_tagged_addr/TestWatchTaggedAddress.py

  Log Message:
  [lldb][AArch64] Fix tagged watch test on Graviton 3

During __do_global_dtors_aux glibc sets a flag that is right
next to the global variable. This is done using a store byte.

On QEMU the watchpoints are handled with a finer granularity
than real hardware, so this wasn't a problem. On Graviton 3
(and Mountain Jade, though this test won't run there) watchpoints
look at larger chunks of memory.

This means that the final continue actually stops in  __do_global_dtors_aux
instead of exiting.

We could fix this by padding the global to be away from the flag,
but that is fiddly and it is easier just to remove the watchpoint
before the final continue. We have already verified it worked by that

Reviewed By: omjavaid

Differential Revision: https://reviews.llvm.org/D154201

More information about the All-commits mailing list