[all-commits] [llvm/llvm-project] 19a350: ValueTracking: Handle !absolute_symbol in computeK...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Wed Jun 28 04:33:40 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 19a35041c0cccb70e61ae80c00092dd6c9a10dcd
      https://github.com/llvm/llvm-project/commit/19a35041c0cccb70e61ae80c00092dd6c9a10dcd
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M llvm/lib/Analysis/ValueTracking.cpp
    M llvm/unittests/Analysis/ValueTrackingTest.cpp

  Log Message:
  -----------
  ValueTracking: Handle !absolute_symbol in computeKnownBits

Use a unit test since I don't see any existing uses try to make use of
the high bits of a pointer.

This will also assert if the metadata type doesn't match the pointer
width, but I consider that a defect in the verifier and shouldn't be
handled.

AMDGPU allocates LDS globals by assigning !absolute_symbol with the
final fixed address. Tracking the high bits are 0 may help with
addressing mode matching.


  Commit: 17f564f305e6a6b01af9fb929067ba85ba74d7a8
      https://github.com/llvm/llvm-project/commit/17f564f305e6a6b01af9fb929067ba85ba74d7a8
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M openmp/libomptarget/cmake/Modules/LibomptargetGetDependencies.cmake

  Log Message:
  -----------
  OpenMP: Revert accidental cmake change to make amdgpu-arch errors fatal

I still think this should be done but should be done separately.


Compare: https://github.com/llvm/llvm-project/compare/f0a290faf801...17f564f305e6


More information about the All-commits mailing list