[all-commits] [llvm/llvm-project] 4bb3d0: Revert D153927 "Resubmit with fix: [NFC] Refactor ...

Fangrui Song via All-commits all-commits at lists.llvm.org
Wed Jun 28 00:31:06 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4bb3d0e5318ef6083596853daf59f0bdb4700d55
      https://github.com/llvm/llvm-project/commit/4bb3d0e5318ef6083596853daf59f0bdb4700d55
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-06-28 (Wed, 28 Jun 2023)

  Changed paths:
    M llvm/include/llvm/Analysis/ProfileSummaryInfo.h
    M llvm/include/llvm/Transforms/Utils/SizeOpts.h
    M llvm/lib/Analysis/ProfileSummaryInfo.cpp
    M llvm/lib/CodeGen/MachineSizeOpts.cpp
    M llvm/lib/Transforms/Utils/SizeOpts.cpp

  Log Message:
  -----------
  Revert D153927 "Resubmit with fix: [NFC] Refactor MBB hotness/coldness into templated PSI functions."

This reverts commit 4d8cf2ae6804e0d3f2b668dbec0f5c1983358328.

There is a library layering violation. LLVMAnalysis cannot depend on LLVMCodeGen.

```
llvm/include/llvm/Analysis/ProfileSummaryInfo.h:19:10: fatal error: 'llvm/CodeGen/MachineFunction.h' file not found
   19 | #include "llvm/CodeGen/MachineFunction.h"
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```




More information about the All-commits mailing list