[all-commits] [llvm/llvm-project] ca7914: [lldb] Avoid FileSystem::Resolve for cached files ...

Jonas Devlieghere via All-commits all-commits at lists.llvm.org
Tue Jun 27 14:19:16 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ca7914564e676fe52fa80049d9c6932653522424
      https://github.com/llvm/llvm-project/commit/ca7914564e676fe52fa80049d9c6932653522424
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2023-06-27 (Tue, 27 Jun 2023)

  Changed paths:
    M lldb/include/lldb/Core/SourceManager.h
    M lldb/include/lldb/Host/FileSystem.h
    M lldb/source/Core/SourceManager.cpp
    M lldb/source/Host/common/FileSystem.cpp
    M lldb/unittests/Core/SourceManagerTest.cpp

  Log Message:
  -----------
  [lldb] Avoid FileSystem::Resolve for cached files in the SourceManager

Currently, source files are cached by their resolved path. This means
that before we can query the cache, we potentially have to resolve the
path, which can be slow. This patch avoids the call to FileSystem::Resolve
by caching both the resolved and unresolved path. We now only resolve
the path once when we create and cache a new file.

rdar://110787562

Differential revision: https://reviews.llvm.org/D153726




More information about the All-commits mailing list