[all-commits] [llvm/llvm-project] 0b2c0d: [ASan] Remove sanity checks during annotation of c...

Tacet via All-commits all-commits at lists.llvm.org
Mon Jun 26 21:07:19 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0b2c0dc63faa51835b864f1277f4d5ddffc49f6c
      https://github.com/llvm/llvm-project/commit/0b2c0dc63faa51835b864f1277f4d5ddffc49f6c
  Author: Advenam Tacet <advenam.tacet at trailofbits.com>
  Date:   2023-06-27 (Tue, 27 Jun 2023)

  Changed paths:
    M compiler-rt/lib/asan/asan_poisoning.cpp

  Log Message:
  -----------
  [ASan] Remove sanity checks during annotation of contiguous container

This revision removes sanity checks in
`__sanitizer_annotate_contiguous_container`.
(Changed them to `DCHECK_EQ`.)
Those checks may be problematic, if someone manually unpoisoned memory block.
Manual unpoisoning may be used if part of the program is not
instrumented.

Those checks are helpful while confirming correctness of ASan annotations
implementation.

Originally suggested here: https://reviews.llvm.org/D136765#4174546

Reviewed By: vitalybuka

Differential Revision: https://reviews.llvm.org/D145482




More information about the All-commits mailing list