[all-commits] [llvm/llvm-project] e28b3e: [DWARF] Adjust warning condition for .dwo sections...

[Fangrui Song via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e28b3ea52aa68114ad9862ba2609042556d713ae
      https://github.com/llvm/llvm-project/commit/e28b3ea52aa68114ad9862ba2609042556d713ae
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-06-24 (Sat, 24 Jun 2023)

  Changed paths:
    M llvm/lib/DebugInfo/DWARF/DWARFContext.cpp
    M llvm/test/DebugInfo/X86/dwarfdump-rela-dwo.s

  Log Message:
  -----------
  [DWARF] Adjust warning condition for .dwo sections with relocations

D106624 added a .dwo warning (when there are relocations) that may fire for
non-debug sections, e.g. `.rodata.dwo` when there is a data symbol foo in
-fdata-sections mode. Adjust it to only warn for .debug sections.

While here, change the diagnostic to be more conventional
https://llvm.org/docs/CodingStandards.html#error-and-warning-messages and use
the relocated section name instead of the relocation section name.

This change does not handle `.zdebug` (support was mostly removed from LLVM) or
`__debug` (Mach-O, no DWO support).

Reviewed By: ayermolo, HaohaiWen

Differential Revision: https://reviews.llvm.org/D153602