[all-commits] [llvm/llvm-project] abe34c: [Pseudo Probe] Remove the assert of allowing only ...

Hongtao Yu via All-commits all-commits at lists.llvm.org
Fri Jun 23 16:41:32 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: abe34ce4e3ba460743150dea7c8d557cd6ba6eb0
      https://github.com/llvm/llvm-project/commit/abe34ce4e3ba460743150dea7c8d557cd6ba6eb0
  Author: Hongtao Yu <hoy at fb.com>
  Date:   2023-06-23 (Fri, 23 Jun 2023)

  Changed paths:
    M llvm/lib/MC/MCPseudoProbe.cpp

  Log Message:
  -----------
  [Pseudo Probe] Remove the assert of allowing only one call probe for a callsite.

Compiler-generated static symbols, such as the global initializers, can shared the same name and can coexist in the binary. As a result, their pseudo probes are all kept in the binary too. This could cause multiple call probes decoded against one callsite, as probes are decoded against there owning functions by name. I'm temporarily disabling an assert to keep the debug build green until we have a better fix.

Reviewed By: wenlei

Differential Revision: https://reviews.llvm.org/D153588




More information about the All-commits mailing list