[all-commits] [llvm/llvm-project] 85f40f: [lldb] Print unprintable characters as unsigned

[Jonas Devlieghere via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 85f40fc676df65416568750f328c71758c84264a
      https://github.com/llvm/llvm-project/commit/85f40fc676df65416568750f328c71758c84264a
  Author: Jonas Devlieghere <jonas at devlieghere.com>
  Date:   2023-06-23 (Fri, 23 Jun 2023)

  Changed paths:
    M lldb/source/Core/DumpDataExtractor.cpp
    M lldb/unittests/Core/DumpDataExtractorTest.cpp

  Log Message:
  -----------
  [lldb] Print unprintable characters as unsigned

When specifying the C-string format for dumping memory, we treat
unprintable characters as signed. Whether a character is signed or not
is implementation defined, but all printable characters are signed.
Therefore it's fair to assume that unprintable characters are unsigned.

Before this patch, "\xcf\xfa\xed\xfe\f" would be printed as
"\xffffffcf\xfffffffa\xffffffed\xfffffffe\f". Now we correctly print the
original string.

rdar://111126134

Differential revision: https://reviews.llvm.org/D153644