[all-commits] [llvm/llvm-project] 3a5715: [LSR] Return nullptr from getExpr if the result is...

Florian Hahn via All-commits all-commits at lists.llvm.org
Thu Jun 22 11:11:12 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3a57152d85e1b9f993871d550846f193ab91450c
      https://github.com/llvm/llvm-project/commit/3a57152d85e1b9f993871d550846f193ab91450c
  Author: Florian Hahn <flo at fhahn.com>
  Date:   2023-06-22 (Thu, 22 Jun 2023)

  Changed paths:
    M llvm/include/llvm/Analysis/IVUsers.h
    M llvm/lib/Analysis/IVUsers.cpp
    M llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp
    M llvm/test/Transforms/LoopStrengthReduce/X86/pr62660-normalization-failure.ll
    M llvm/test/Transforms/LoopStrengthReduce/scaling-factor-incompat-type.ll

  Log Message:
  -----------
  [LSR] Return nullptr from getExpr if the result isn't invertible.

getExpr is missing a check to make sure the result is invertible.
This can lead to incorrect results, so return nullptr in those cases
like in other places in IVUsers.

Fixes #62660.

Reviewed By: qcolombet

Differential Revision: https://reviews.llvm.org/D153202




More information about the All-commits mailing list