[all-commits] [llvm/llvm-project] f55fd1: Define/guard MLIR_STANDALONE_BUILD LLVM_LIBRARY_OU...

[Stella Laurenzo via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f55fd19b6b565827af5fbf504952dcc35b8b7360
      https://github.com/llvm/llvm-project/commit/f55fd19b6b565827af5fbf504952dcc35b8b7360
  Author: Stella Laurenzo <stellaraccident at gmail.com>
  Date:   2023-06-20 (Tue, 20 Jun 2023)

  Changed paths:
    M llvm/cmake/modules/AddLLVM.cmake
    M mlir/CMakeLists.txt

  Log Message:
  -----------
  Define/guard MLIR_STANDALONE_BUILD LLVM_LIBRARY_OUTPUT_INTDIR var.

It looks like MLIR is using the more modern CMAKE_LIBRARY_OUTPUT_DIRECTORY, but AddLLVM still uses this older LLVM specific alias.

In the specific case I was running into, the empty variable was causing `-Wl,-rpath-link,` on the command line, causing the following argument to be swallowed. This was maddening, because the following argument was the .o file containing `main` and I was getting `main` undefined errors when it was clearly there. This is egregious enough that I chose to guard it.

Differential Revision: https://reviews.llvm.org/D153373