[all-commits] [llvm/llvm-project] bba2b6: [mlir][RunnerUtils] Make symbols private + impleme...

Ingo Müller via All-commits all-commits at lists.llvm.org
Tue Jun 20 12:28:47 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: bba2b656110209a3d9863b92c060082479b06ab1
      https://github.com/llvm/llvm-project/commit/bba2b656110209a3d9863b92c060082479b06ab1
  Author: Ingo Müller <ingomueller at google.com>
  Date:   2023-06-20 (Tue, 20 Jun 2023)

  Changed paths:
    M mlir/lib/ExecutionEngine/CMakeLists.txt
    M mlir/lib/ExecutionEngine/RunnerUtils.cpp

  Log Message:
  -----------
  [mlir][RunnerUtils] Make symbols private + implement loading mechanism.

There are two ways to make symbols from a shared library visible in the
execution engine: exporting the symbols with public visibility or
implementing a loading/unloading mechansim that registers the exported
symbols explicitly. The latter has only been available in the JIT runner
until recently, but https://reviews.llvm.org/D153029 makes it available
in any usage of the execution engine (including the Python bindings).

This patch makes the runner utils library use the latter mechanism
instead of the former, i.e., it makes all of its symbols private and
implements the init/destroy functions of the loading mechanism to
control explicitly which symbols it registers.

Reviewed By: mehdi_amini

Differential Revision: https://reviews.llvm.org/D153250




More information about the All-commits mailing list