[all-commits] [llvm/llvm-project] f31f4a: [DebugInfo][NFC] Remove dead lines of test input

Felipe de Azevedo Piovezan via All-commits all-commits at lists.llvm.org
Tue Jun 20 11:29:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f31f4adea1f1752dc4b6e3f6b4228b809295f979
      https://github.com/llvm/llvm-project/commit/f31f4adea1f1752dc4b6e3f6b4228b809295f979
  Author: Felipe de Azevedo Piovezan <fpiovezan at apple.com>
  Date:   2023-06-20 (Tue, 20 Jun 2023)

  Changed paths:
    M llvm/test/DebugInfo/accel-tables-apple.ll

  Log Message:
  -----------
  [DebugInfo][NFC] Remove dead lines of test input

This test uses a separate input file, so its IR is meaningless.

Differential Revision: https://reviews.llvm.org/D153274


  Commit: 8af224d52cad1380996ed84174d0b01a17d52759
      https://github.com/llvm/llvm-project/commit/8af224d52cad1380996ed84174d0b01a17d52759
  Author: Felipe de Azevedo Piovezan <fpiovezan at apple.com>
  Date:   2023-06-20 (Tue, 20 Jun 2023)

  Changed paths:
    M llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
    M llvm/test/DebugInfo/accel-tables-apple.ll

  Log Message:
  -----------
  [DebugInfo] Fix emission of empty debug_names for Apple

D118754 added a new DICompileUnit::DebugNameTableKind for "Apple", so that,
under DWARF 5, the following combination is used inside DwarfDebug.cpp:

```
(lldb) p getAccelTableKind()
(llvm::AccelTableKind) $6 = Dwarf
(lldb) p CU.getNameTableKind()
(llvm::DICompileUnit::DebugNameTableKind) $7 = Apple
```

This creates a problem in the if statements changed, whereby "for non Apple
AccelTableKind" we emit empty tables for any DebugNameTableKind that is not
"Default". We should consider the newly added kind here too.

Note that our existing test could have caught this, if only it had checked the
_contents_ of the table, instead of merely checking for the existence of the
section.

Differential Revision: https://reviews.llvm.org/D153275


Compare: https://github.com/llvm/llvm-project/compare/7ddda854d80c...8af224d52cad


More information about the All-commits mailing list